pFind bug

[MochiMoppel]

Observed in pFind 6.3 of BookwormPup64 10.0.8

pFind never finds any match when selecting
[X] Search only current filesystem (IMHO this should be the default!)
Permissions in the "Mode" category. e.g. the very typical Read access for all and Write access for user

When constructing the find command pFind fails to separate the -perm 644 and -xdev arguments with the mandatory whitespace, resulting in an invalid command construct (see statusbar).

I don't expect that this will be fixed. pFind is unmaintained for a long time and has quite a few unresolved problems. Just stating it here for the record.

[rockedge]

time to look at the code and see it is fixed for the future.

[wizard]

@MochiMoppel
@rockedge

Cannot confirm bug based on following test.

BookwormPup64 10.0.7 and 10.0.8.
Pfind 6.3
search for = smb
Where to search = System files
Search only current file system

Returns expected results.

Did I miss something?

Thanks
wizard

[bigpup]

@MochiMoppel

you seem to have a good understanding of the code in this program.

If no one is maintaining it.

How about you taking it over and do the maintaining?

This is one of the must have programs in any Puppy Linux version.

sure would be good if it stayed working correctly.

[don570]

Zigbert will solve the problem if he is asked.

I pointed out a problem with Dollar signs and other strange characters in folder names
and he solved it
Remember that the name of the program is pfind/pfilesearch when contacting Zigbert
https://forum.puppylinux.com/viewtopic.php?t=6672
________________________________________________________-

Screenshot 2024-10-09 12.44.25.png (15.43 KiB) Viewed 1326 times

[MochiMoppel]

Returns expected results.
Did I miss something?

Permissions

[peebee]

Please provide the fix and I will apply it to:
https://github.com/puppylinux-woof-CE/w ... ages/pfind

for future Woof-CE builds.

[MochiMoppel]

pFind will also fail when using these options:
☐ Search also subdirectories
☒ Search only current filesystem

This all points to an obvious cause.. and raises a suspicion that some options in pFind are never used

[MochiMoppel]

@peebee Add the missing space to line 76 of
https://github.com/puppylinux-woof-CE/w ... earch/func

[ "$CHKXDEV" = "true" ] && XDEV=" -xdev" || XDEV=""

And just in case you are wondering: Yes, this bug exists since the very first version.
Found this in pfilesearch v.1.11 of 2008:
if [ $CHKXDEV = "true" ]; then XDEV="-xdev"; else XDEV=""; fi

@Dry Falls I doubt that this has anything to do with gtkdialog. Which other bugs did you experience?

[peebee]

done:
https://github.com/puppylinux-woof-CE/w ... 5822c2766a

[fredx181]

...
And just in case you are wondering: Yes, this bug exists since the very first version.
Found this in pfilesearch v.1.11 of 2008:
if [ $CHKXDEV = "true" ]; then XDEV="-xdev"; else XDEV=""; fi

Yes, you are very, very late discovering this bug !

Works fine now with the space before -xdev XDEV=" -xdev", thanks