xorgwizard call function from different script (using LunarPup)

[AntonioPt]

Hello all,

I was working in xorgwizard today, try to improve translation and to clean a bit better all so and i notice an odd issue.

When calling a second GUI from xorgwizard "My xorgwizard in a different path" i notice that the script is calling the function from the OS /usr/sbin/xorgwizard instead of mine can anyone explain me why this is happening ?

Gonna share a link of my website with a video of 6mb since i can't share it here for being to big
P.S. this is from LunarPup
[media]http://patinsemlinhaslalom.altervista.o ... wizard.mp4[/media]

@norgo @bigpup @nilsonmorales @rockedge @BarryK @josejp2424 @mikewalsh ... sorry if i mention too many but you guys are the ones at the top of my head and thxx in advance

[AntonioPt]

Just realize today when i click in xorgwizard-cli OS frozen /LunarPup, FossaPup, Bookworm and maybe many others

[josejp2424]

Hello all,

I was working in xorgwizard today, try to improve translation and to clean a bit better all so and i notice an odd issue.

When calling a second GUI from xorgwizard "My xorgwizard in a different path" i notice that the script is calling the function from the OS /usr/sbin/xorgwizard instead of mine can anyone explain me why this is happening ?

Gonna share a link of my website with a video of 6mb since i can't share it here for being to big
P.S. this is from LunarPup
[media]http://patinsemlinhaslalom.altervista.o ... wizard.mp4[/media]

@norgo @bigpup @nilsonmorales @rockedge @BarryK @josejp2424 @mikewalsh ... sorry if i mention too many but you guys are the ones at the top of my head and thxx in advance

Those scripts have always been there. In addition to xorgwizard, there are also xorgwizard-cli, xorgwizard-automatic, and xserverwizard, which are symbolic links (symlinks) pointing to xorgwizard.

Greetings.

[AntonioPt]

yeah i know but there is bugs and i was wondering why it calls function out the script that im working, then xorgwizard-cli if you click on it will frozen machine lol

Anyway gonna see for solutions even if i have to do some from scratch

Hello all,

I was working in xorgwizard today, try to improve translation and to clean a bit better all so and i notice an odd issue.

When calling a second GUI from xorgwizard "My xorgwizard in a different path" i notice that the script is calling the function from the OS /usr/sbin/xorgwizard instead of mine can anyone explain me why this is happening ?

Gonna share a link of my website with a video of 6mb since i can't share it here for being to big
P.S. this is from LunarPup
[media]http://patinsemlinhaslalom.altervista.o ... wizard.mp4[/media]

@norgo @bigpup @nilsonmorales @rockedge @BarryK @josejp2424 @mikewalsh ... sorry if i mention too many but you guys are the ones at the top of my head and thxx in advance

Those scripts have always been there. In addition to xorgwizard, there are also xorgwizard-cli, xorgwizard-automatic, and xserverwizard, which are symbolic links (symlinks) pointing to xorgwizard.

Greetings.

[MochiMoppel]

xorgwizard-cli if you click on it will frozen machine

The file has -cli in its name, indicating that it MUST be run from a terminal. I don't understand why you expect it to work when you do NOT run it from a terminal.
Please review your previous post. Same issue. Your mistake and not a bug.

However I do see a problem of the xorgwizard script, starting at line 12

Code: Select all

[ -z "$DISPLAY" -a -z "$WAYLAND_DISPLAY" ] && CLI=1
[ "$XDG_SESSION_TYPE" = 'wayland' ] && CLI=''
case $script in
	xorgwizard-cli) CLI=1 ;;
	xorgwizard-automatic) AUTOMATIC=1 ;;
esac

It seems to me that the line xorgwizard-cli) CLI=1 ;; shouldn't exist. It overrides the setting for the CLI variable of the first line, without checking if the necessary conditions are met. The line [ -z "$DISPLAY" -a -z "$WAYLAND_DISPLAY" ] && CLI=1 would sufficiently ensure that xorgwizard or xorgwizard-cli run in cli mode if invoked from a real terminal, not a console window or a GUI. In all other cases both scripts would run in GUI mode, avoiding the problem you encountered.

BTW: The file xorgwizard-automatic, also a symlink to xorgwizard, runs in GUI mode when clicked, so no harm done. However when run from a virtual console window it surprises with the message "If you are reading this, then you are at the console without X running. The usual thing now is to type 'xwin' to start X..."
The usual thing is to ignore this lie because I definitely can read this while running X

[AntonioPt]

xorgwizard-cli if you click on it will frozen machine

The file has -cli in its name, indicating that it MUST be run from a terminal. I don't understand why you expect it to work when you do NOT run it from a terminal.
Please review your previous post. Same issue. Your mistake and not a bug.

However I do see a problem of the xorgwizard script, starting at line 12

Code: Select all

[ -z "$DISPLAY" -a -z "$WAYLAND_DISPLAY" ] && CLI=1
[ "$XDG_SESSION_TYPE" = 'wayland' ] && CLI=''
case $script in
	xorgwizard-cli) CLI=1 ;;
	xorgwizard-automatic) AUTOMATIC=1 ;;
esac

It seems to me that the line xorgwizard-cli) CLI=1 ;; shouldn't exist. It overrides the setting for the CLI variable of the first line, without checking if the necessary conditions are met. The line [ -z "$DISPLAY" -a -z "$WAYLAND_DISPLAY" ] && CLI=1 would sufficiently ensure that xorgwizard or xorgwizard-cli run in cli mode if invoked from a real terminal, not a console window or a GUI. In all other cases both scripts would run in GUI mode, avoiding the problem you encountered.

BTW: The file xorgwizard-automatic, also a symlink to xorgwizard, runs in GUI mode when clicked, so no harm done. However when run from a virtual console window it surprises with the message "If you are reading this, then you are at the console without X running. The usual thing now is to type 'xwin' to start X..."
The usual thing is to ignore this lie because I definitely can read this while running X

Thxx for the feedback but i didn't change nutting this is the "Original code" this is why i was confused beside i all so notice if i run xorgwizard-cli machine frozen and its in all puppys or at least fossa, Lunar and bookworm since i test it in all

[MochiMoppel]

Thxx for the feedback but i didn't change nutting this is the "Original code"

???
I didn't say that you changed anything. My feedback refers to the "Original code". I only tried to explain that you use xorgwizard-cli in a way it should not be used.

[AntonioPt]

Thxx for the feedback but i didn't change nutting this is the "Original code"

???
I didn't say that you changed anything. My feedback refers to the "Original code". I only tried to explain that you use xorgwizard-cli in a way it should not be used.

yeah yeah sorry i didn't mean nutting wrong as well all good and thxx