Page 1 of 1
Woof-CE 3builddistro error/bug/strange definition?
Posted: Sat Mar 20, 2021 3:11 am
by taersh
Hi.
In Woof-CE script 3builddistro at line 258:
EXTRAS_LIST="${ADRV_INC// /|} ${YDRV_INC// /|} ${AFDRV_INC// /|}"
What is that (the red one) ?
I don't think it would be possible to add an afdrv .sfs to Puppy, no?
It seems not to be used in all the Woof-CE scripts.
Re: Woof-CE 3builddistro error/bug/strange definition?
Posted: Sat Mar 20, 2021 9:03 am
by wiak
taersh wrote: ↑Sat Mar 20, 2021 3:11 am
Hi.
In Woof-CE script 3builddistro at line 258:
EXTRAS_LIST="${ADRV_INC// /|} ${YDRV_INC// /|} ${AFDRV_INC// /|}"
What is that (the red one) ?
I don't think it would be possible to add an afdrv .sfs to Puppy, no?
It seems not to be used in all the Woof-CE scripts.
If not intended somehow, then maybe a typo/error and should be ${FDRV_INC// /|}?"
Re: Woof-CE 3builddistro error/bug/strange definition?
Posted: Sat Mar 20, 2021 9:17 am
by dimkr
adrv support works, look at fossa64.
This testing build has a functional adrv - https://github.com/dimkr/woof-CE/releas ... 9.499-adrv
Re: Woof-CE 3builddistro error/bug/strange definition?
Posted: Sat Mar 20, 2021 9:36 am
by dimkr
This ugly and unreadable loop takes a list of packages like "abiword gnumeric" and converts it into "abiword|gnumeric", then passes that through grep, so it filters lines containing one of the package names.
This area had a bug I fixed recently, in https://github.com/puppylinux-woof-CE/w ... 2135/files. 3builddistro didn't filter out comments, so lines containing the word "abiword" in a comment got ignored, and gmp (a dependency of GCC) didn't get added to rootfs-complete, breaking fossa64.
Make sure on you're on the latest woof-CE (git pull), it's fixed now.
EDIT: ha, this typo can break fdrv, not adrv.