Discussion, talk and tips
https://forum.puppylinux.com/
Hello everyone, i just made a small update to TAS script since wasnt displaying some Dialog Boxs "func_dlg () " but problem fix now and i have clean the code a litter bit more gonna clean more and better "at least for my point of view" and i hope this is usefull to every one who loves TAS.
P.S. I rename the version to 1.16 and gonna add more Variables in order to have an option to make multi language translation
If you think that TAS needs fixing I suggest that you contact JakeSFR.
i have clean the code a litter bit more gonna clean more and better "at least for my point of view" and i hope this is usefull to every one who loves TAS.
I made only a quick comparison with TAS 1.15 and your version and found that most of your changes are cosmetic, sometimes reverting to an obsolete syntax style and sometimes potentially wrong, e.g.
Code: Select all
IFS=""is not the same as
Code: Select all
IFS='
'@JakeSFR Is there already a TAS thread in the current forum? I couldn't find one.
Would be nice to have a place where users can post comments, ideas and praise 
Never a good idea to do that. TAS already has a author/maintainer. If you want to change the script you should either contact originator or fork under a different name to avoid user confusion via multiple version uploads, which is just bad practice overall even if the fork contains improvements that some may appreciate.
AntonioPt wrote:Hello everyone, i just made a small update to TAS script since wasnt displaying some Dialog Boxs "func_dlg () " but problem fix now and i have clean the code a litter bit more gonna clean more and better "at least for my point of view" and i hope this is usefull to every one who loves TAS.
P.S. I rename the version to 1.16 and gonna add more Variables in order to have an option to make multi language translation
I looked at the diff and there are some strange, breaking changes, like LANG=C, which basically disables the use of other translations than English.
Another one:
Code: Select all
if [ "${1}" != "relaunch" ] && [ "`xwininfo -root | grep -w Depth | awk '{print $2}'`" -lt 26 ] ; then
func_dlg WARN "$(gettext "Color depth is lower than 24bits.")" \
"$(gettext "TAS may not work 100% properly.")" \
"$(gettext "Try to use 'xorgwizard' to change the setting.")"
fiwhere 24 was for some reason increased to 26, what makes this warning always show up at startup, unnecessarily.
The IFS mentioned by Mochi - with your modification using spaces in output filename doesn't work anymore.
So, can you tell me what is the actual problem with TAS and I'll see how to address it?
___________
MochiMoppel wrote:@JakeSFR Is there already a TAS thread in the current forum? I couldn't find one.
Would be nice to have a place where users can post comments, ideas and praise
No, I don't think so, I couldn't find it either. Fixed: viewtopic.php?p=71991
Greetings!
MochiMoppel wrote: ↑Wed Nov 09, 2022 6:00 amIf you think that TAS needs fixing I suggest that you contact JakeSFR.
i have clean the code a litter bit more gonna clean more and better "at least for my point of view" and i hope this is usefull to every one who loves TAS.
I made only a quick comparison with TAS 1.15 and your version and found that most of your changes are cosmetic, sometimes reverting to an obsolete syntax style and sometimes potentially wrong, e.g.
Code: Select all
IFS=""is not the same as
Code: Select all
IFS=' '@JakeSFR Is there already a TAS thread in the current forum? I couldn't find one.
Would be nice to have a place where users can post comments, ideas and praise
Thxx for your Replay,... but im new with bash and all this stuff about updates,... but next time i will take that into acount,... Thank you very much.
P.S yes most of the code are cosmetic since its the way i make code "so that i can get it/understand better for my self thats all" but version 1.15 if you run via terminal the dialogs don't display 
JakeSFR wrote: ↑Wed Nov 09, 2022 11:05 amAntonioPt wrote:Hello everyone, i just made a small update to TAS script since wasnt displaying some Dialog Boxs "func_dlg () " but problem fix now and i have clean the code a litter bit more gonna clean more and better "at least for my point of view" and i hope this is usefull to every one who loves TAS.
P.S. I rename the version to 1.16 and gonna add more Variables in order to have an option to make multi language translationI looked at the diff and there are some strange, breaking changes, like
LANG=C, which basically disables the use of other translations than English.Another one:
Code: Select all
if [ "${1}" != "relaunch" ] && [ "`xwininfo -root | grep -w Depth | awk '{print $2}'`" -lt 26 ] ; then func_dlg WARN "$(gettext "Color depth is lower than 24bits.")" \ "$(gettext "TAS may not work 100% properly.")" \ "$(gettext "Try to use 'xorgwizard' to change the setting.")" fiwhere 24 was for some reason increased to 26, what makes this warning always show up at startup, unnecessarily.
The
IFSmentioned by Mochi - with your modification using spaces in output filename doesn't work anymore.So, can you tell me what is the actual problem with TAS and I'll see how to address it?
___________MochiMoppel wrote:@JakeSFR Is there already a TAS thread in the current forum? I couldn't find one.
Would be nice to have a place where users can post comments, ideas and praiseNo, I don't think so, I couldn't find it either. Fixed: viewtopic.php?p=71991
Greetings!
Hi there @JakeSFR , yes you are right about that i did it on porpuse to test if func_dlg popup correcly since 1.15 in fossa wont display and in Racypup "yes this old pupy didnt run too 
" but soon i will post in the link you just send me with more updates and then you tell me what you think,... since im new and didnt got no clue where to share my code/ideia,... and thankyou for all Replay/comment/feedback,... P.S. this tool its supose to creat a Gif animation too ? because i notice more "issues/flaws" but anyway tomorrow or so i hope to share a better code that i implement then tell me what you think,....
wiak wrote: ↑Wed Nov 09, 2022 6:42 amNever a good idea to do that. TAS already has a author/maintainer. If you want to change the script you should either contact originator or fork under a different name to avoid user confusion via multiple version uploads, which is just bad practice overall even if the fork contains improvements that some may appreciate.
Thankyou next time i will take that into acount,... and thankyou for your replay/comment/feedback,.... Best Regards Antonio
Hello @step thankyou i think this full post of mine will be remove soon since there is another place to talk about it and i didnt express my self very well so there are some updates and sully question from a rockie who is learning bash "Me" but thankyou for all